use client wrapper on tsup #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
colinrobertbrooks
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Uses config to add 'use client'; to shared-ui lib
Why
These components are then compatible with RSC/Next
Future
It would be nice if this wasn't an all-or-nothing approach. Per component eluded my attempts. I think it may have to do with the single-file bundle 🤔
References
This is still early on so some better solutions may come about.
See: egoist/tsup#835
Also: https://nextjs.org/docs/app/building-your-application/rendering/composition-patterns#advice-for-library-authors which references https://github.com/shuding/react-wrap-balancer/blob/main/tsup.config.ts#L10-L13