Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with trace data coming through as tuple #76

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

kgpax
Copy link
Member

@kgpax kgpax commented Sep 25, 2023

🐛 What was the observed bug?

We'd sometimes see a trace row with no data, stuck in a "waiting" state:

image

What was the cause?

Initial traces were being sent to the collector in tuple format, e.g.,

['123456', '{"id":"123456","timestamp":1695642906895, ... }']

...whereas they should always be just the serialised trace:

{"id":"123456","timestamp":1695642906895, ... }

This was a bug in the logic which buffers traces before the WS connection is made, and then flushes them through. It was flushing the items from the buffer's Map, whereas it should just send the values from this map.

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

⚠️ No Changeset found

Latest commit: 72a7227

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kgpax kgpax merged commit f1d6658 into main Sep 25, 2023
3 checks passed
@kgpax kgpax deleted the bug/rogue-trace-row branch September 25, 2023 12:14
@kgpax kgpax mentioned this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants