Fixed issue with trace data coming through as tuple #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 What was the observed bug?
We'd sometimes see a trace row with no data, stuck in a "waiting" state:
What was the cause?
Initial traces were being sent to the collector in tuple format, e.g.,
...whereas they should always be just the serialised trace:
This was a bug in the logic which buffers traces before the WS connection is made, and then flushes them through. It was flushing the items from the buffer's
Map
, whereas it should just send the values from this map.