Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various UI fixes #199

Merged
merged 2 commits into from
Jan 7, 2024
Merged

Various UI fixes #199

merged 2 commits into from
Jan 7, 2024

Conversation

kgpax
Copy link
Member

@kgpax kgpax commented Jan 7, 2024

What does this PR do

Makes various UI tweaks and fixes based on observations using Envy:

Ensure capitalised HTTP verb

Some applications had the HTTP verb (GET, POST, etc) in lowercase, and nothing was ensuring uppercase presentation in the trace details UI, so I've set this to always be uppercase now.

Before After (fix)
image image

Vertically align field names

When writing custom systems with custom request or response details using the <Field> component, any usage which had a multi-line value would mean that the field label would be centre-aligned, rather than top-aligned.

Before After (fix)
image image

Tweaks to inline Monaco code editor

When the Monaco code editor was used to display the decoded authorization header value, it had a couple of problems:

  • It had a fixed height of 200px, regardless of actual content
  • It didn't match the background of the heading of the component
Before After (fix)
image image

Collapsed sections made slightly more obvious

When collapsing a section of the trace details, the content would be hidden but it was not abundantly clear that the section was in the collapsed state. I've now made the text have a 50% opacity, which gives a better visual indication that the section is collapsed.

Before After (fix)
image image

Automatic divider between built-in and custom request or response detail components

Previously, any custom components defined by a system would have no separation from the built-in details in those sections, and authors of those components would need to add in the divider/separation into the UI.

Now, this is done automatically, meaning that custom systems can just supply the component with no divider or padding required.

image

Copy link

changeset-bot bot commented Jan 7, 2024

🦋 Changeset detected

Latest commit: 0f8a6a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@envyjs/webui Patch
@envyjs/apollo Patch
@envyjs/core Patch
@envyjs/nextjs Patch
@envyjs/node Patch
@envyjs/web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kgpax kgpax merged commit 8bdc3de into main Jan 7, 2024
2 checks passed
@kgpax kgpax deleted the fix/ui-fixes branch January 7, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants