Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-visit image parsing in liveItem #44

Open
matthew-carroll opened this issue Jan 13, 2024 · 0 comments
Open

Re-visit image parsing in liveItem #44

matthew-carroll opened this issue Jan 13, 2024 · 0 comments
Labels
area_podcast bounty_donation Non-compensated work p2 Definitely want it, but timing isn't important

Comments

@matthew-carroll
Copy link
Collaborator

A liveItem element can have an images element like the following:

<podcast:images srcset="https://example.com/images/live/pci_avatar-massive.jpg 1500w,
        https://example.com/images/live/pci_avatar-middle.jpg 600w,
        https://example.com/images/live/pci_avatar-small.jpg 300w,
        https://example.com/images/live/pci_avatar-tiny.jpg 150w"
    />

This is currently being parsed in RssPodcastIndexLiveItemImages, but the parser produces a list of RegExp, not a list of strings. Moreover, it might be more appropriate to represent each image in a structured way, given that these image values contain a URL and possible width and height values.

Revisit this parser, fix it up, and consider add structured data in place of strings.

https://github.com/Podcastindex-org/podcast-namespace/blob/main/docs/1.0.md#live-item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area_podcast bounty_donation Non-compensated work p2 Definitely want it, but timing isn't important
Projects
None yet
Development

No branches or pull requests

1 participant