Skip to content
This repository has been archived by the owner on Mar 10, 2024. It is now read-only.

Dark mode toggle not working #51

Closed
t347s opened this issue Jun 15, 2023 · 4 comments
Closed

Dark mode toggle not working #51

t347s opened this issue Jun 15, 2023 · 4 comments
Labels
wontfix This will not be worked on

Comments

@t347s
Copy link

t347s commented Jun 15, 2023

Hi,
The toggle button does not change the theme:
image

Tested on latest version of Firefox and Chrome.

Thank you!

@Flowko
Copy link
Owner

Flowko commented Jun 15, 2023

hi, which website ?

@Flowko
Copy link
Owner

Flowko commented Jun 15, 2023

because what that option does is basiclly set prefers-color-scheme to either dark or light , which is supported on all modern browsers, so not sure about the website you trying to test.

tested with Github:

light mode

image

dark mode

image

@t347s
Copy link
Author

t347s commented Jun 15, 2023

UPS! I understand now what this button functionality, from info icon i undestood that the your solution is changing the color to dark, not the captured website.

UPS again!

Can you make it more explicit here?
image

So to be more clear something link: "Capture dark mode of website" / "Capture light mode of website"

Thank you!

@Flowko
Copy link
Owner

Flowko commented Jun 15, 2023

yeah for sure, im planning to do a big update to this repo, from the framework used to styling and more features, ill keep that in mind, thanks

@Flowko Flowko closed this as completed Jun 15, 2023
@Flowko Flowko added the wontfix This will not be worked on label Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants