Icon coloring for links

[LandonSchropp]

Describe the bug

When an icon is included as part of a link to another page, it doesn't share the color of the link in edit mode.

Here's an example of what the icon looks like in the file tree:

And here's an example of the icon within the link:

And how it renders when the cursor isn't inside the link:

The icon color is also off for icons pasted directly into links:

To Reproduce

Steps to reproduce the behavior:

1. In a new vault, install the Iconize plugin and enable it.
2. Create a new page named Pizza.
3. Set the Pizza page's icon to LiPizza
4. Create a new page
5. Paste in a link to the pizza page: [[Pizza]]

Another way to reproduce this is to add an icon explicitly in a link.

1. In a new vault, install the Iconize plugin and enable it.
2. Create a new page
3. Paste in the following markdown: [:LiPizza: Pizza](http://example.com)

Expected behavior

In my opinion, the icon should be inside the anchor. I'd expect it to match the link's color.

Additional context

Thanks for the great plugin!

[LandonSchropp]

To solve this issue for myself, I added the following CSS snippet:

.iconize-icon-in-link {
  color: var(--link-color);
}

However, this feels like something that should be solved in the plugin, so I'll leave this issue open. 🙂

[ShaneNZ]

I use the colour configuration for the icons, so my folder view looks like this (ignore the background colours, that's just extra CSS):

Rather than the inline links matching the link colour, I'd actually like them to match the colours as set in the plugin and visible in the file explorer.

Not sure if this is the same or different request, but there's an obvious overlap so adding the comment here.

[LandonSchropp]

@ShaneNZ Maybe the icons could default to the link color unless a custom color is set, in which case they'd use that instead?

[ShaneNZ]

I think that's a perfect solution!

…

On Fri, 18 Oct 2024, 7:17 am Landon Schropp, ***@***.***> wrote: @ShaneNZ <https://github.com/ShaneNZ> Maybe the icons could default to the link color unless a custom color is set, in which case they'd use that instead? — Reply to this email directly, view it on GitHub <#571 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATIKVVYA7YOPRGZ5NTTGWLZ375KNAVCNFSM6AAAAABPCABOE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRQGIZDOOBSHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>