ID-3375 [FIX] Ensure Matrix field does not create extra columns in DS if the form has extra field, when user submits it #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaJadhavXoriant
changed the title
NikitaJadhavXoriant
changed the title
tonytlwu
requested changes
Aug 2, 2023
js/libs/form.js
Outdated
| formData._flSchema.excludedFields = []; | ||
|
|
||
| _.forEach(field.rowOptions, function(row) { | ||
| var val = row.id ? row.id : row.label; |
There was a problem hiding this comment.
Suggested change
| var val = row.id ? row.id : row.label; | |
| var val = row.id || row.label; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product areas affected
Studio -> Form -> Matrix
What does this PR do?
Implemented code, so when user submit Form with matrix and other field, it should not create extra Matrix column.
JIRA ticket
click here
Result
Test-3375.mp4
Checklist
None
Testing instructions
None
Deployment instructions
None
Author concerns
None