We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the utils.ts file, the function below is used to send request via Fetch API:
const requestWrapper = (): Promise<Response> => { return new Promise((resolve, reject) => { let timeoutId: NodeJS.Timeout; if (timeout) { timeoutId = setTimeout(() => reject('error: timeout'), timeout); } return fetch(url, fetchOptions) .then(res => resolve(res)) .catch(err => reject(err)) .finally(() => { if (timeoutId) { clearTimeout(timeoutId); } }); }); };
This is timing out the promise, but not really aborting the request, which keeps http connections open hanging.
It'd be nice if abort signal was used so the http connection is also closed.
The text was updated successfully, but these errors were encountered:
Thanks for raising this @AlissonRS, and submitting a PR. I've added a comment to the PR - let's continue the discussion there.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
In the utils.ts file, the function below is used to send request via Fetch API:
This is timing out the promise, but not really aborting the request, which keeps http connections open hanging.
It'd be nice if abort signal was used so the http connection is also closed.
The text was updated successfully, but these errors were encountered: