Family member search #160
Open
Family member search #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junzai97
added
bug
HowardYaw
reviewed
Nov 19, 2021
| dropdownOpen: false, | ||
| selectedYearSession: '2019/2020', | ||
| memberName: '', | ||
| yearSessionList: ['2019/2020', '2020/2021', '2021/2022', '2022/2023', '2023/2024', '2024/2025', '2025/2026'], |
There was a problem hiding this comment.
why this one hardcoded?
not get from BE?
There was a problem hiding this comment.
or this PR is just for UI?
There was a problem hiding this comment.
This file was pulled from #159. But for this PR, I mainly implement the search function into family-member search. Not sure why it still displaying this part of code as this is already existed in the dev-version-2 branch
HowardYaw
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #157