Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReStock: SM-6A Service Module #404

Open
hockeygoalie35 opened this issue Mar 9, 2024 · 4 comments
Open

ReStock: SM-6A Service Module #404

hockeygoalie35 opened this issue Mar 9, 2024 · 4 comments
Labels
C# Requires code CFG Requires modulemanager patches or configs enhancement New feature or request Mod Support Related to supporting parts/ivas from some other mod tricky More complex than first glance
Milestone

Comments

@hockeygoalie35
Copy link

The Restock variant of the Making History 1.25 to 0.625m "SM-6A Service Module" has an option for a docking tunnel. Any chance this can be added to the next release? (ignore the naming in the photo)

Snipaste-2024-03-08-19-30-25

@hockeygoalie35 hockeygoalie35 changed the title ReStock: ReStock: SM-6A Service Module Mar 9, 2024
@JonnyOThan JonnyOThan added CFG Requires modulemanager patches or configs Mod Support Related to supporting parts/ivas from some other mod enhancement New feature or request labels Mar 9, 2024
@JonnyOThan JonnyOThan added this to the 1.0.0 milestone Mar 9, 2024
@JonnyOThan JonnyOThan added tricky More complex than first glance C# Requires code labels Mar 19, 2024
@JonnyOThan
Copy link
Collaborator

This is a little harder than it seems at first glance because Restock+ adds a variant instead of B9PS. The attachnodes don't change with the variants, so FreeIva doesn't currently have a way to support making it passable only when that variant is selected.

@hockeygoalie35
Copy link
Author

Hmm…would it be possible to just support it as is, or is it within the spirit of the mod to stay as accurate as possible?

I’m not super familiar with module manager patches, but is it possible to convert the variant to a B9PS?

@JonnyOThan
Copy link
Collaborator

Yes, two options that I've considered are applying patches to make the variants use a different set of attachnodes, or switching it to use b9ps instead.

However, those approaches would only work for newly created and launched craft - any old designs or ships in flight wouldn't be updated.

So I think FreeIVA needs to be able to conditionally provide passthrough or an internal based on the part variant. I think there is a module in WBI tools somewhere that does this already too.

@JonnyOThan
Copy link
Collaborator

Hmm…there might be a way to tie a b9ps subtype to a stock variant selection…that would probably be the cleanest path forward if it exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Requires code CFG Requires modulemanager patches or configs enhancement New feature or request Mod Support Related to supporting parts/ivas from some other mod tricky More complex than first glance
Projects
None yet
Development

No branches or pull requests

2 participants