Wipe out multi-file database support #8047
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For v6 I would suggest to drop ability to create multifile database but keep ability to open and work with multifile database until the next major ODS. |
Don't need this. For this purpose there is EngineXX of previous versions. |
|
XX will be the same in v4/v5 and v6, this makes things confusing. Different engines are mostly intended for different major ODS versions. |
|
Not anymore. In Firebird 6.0, now the new major version ODS 14.0. |
|
Yes, but tablespaces are still in the pipeline. Does anyone object to perform the cleanup now? |
|
Updated, ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure it should be applied to v6 as it supports databases in ODS 13.0 / 13.1 which may be multi-file and the engine will not be able to work with them. The patch raises an error in this case and suggests backup/restore to convert the database into a single file. Another possible reason for delay is that tablespaces are not landed yet. I have no problems merging this PR later.