Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core_4964_test.py fail on Firebird debug build #27

Open
aafemt opened this issue Jul 31, 2024 · 1 comment
Open

core_4964_test.py fail on Firebird debug build #27

aafemt opened this issue Jul 31, 2024 · 1 comment

Comments

@aafemt
Copy link
Contributor

aafemt commented Jul 31, 2024

Debug build of Firebird sends the real auth errors to client in addition to logging it into firebird.log. Because of this the test's output is not as expected. It is a false negative.

>       assert act.clean_stdout == act.clean_expected_stdout
E       assert
E           Statement failed, SQLSTATE = 08006
E           Error occurred during login, please check server firebird.log for details
E         + -file is not a valid database

tests\bugs\core_4964_test.py:116: AssertionError
pavel-zotov added a commit that referenced this issue Jul 31, 2024
@pavel-zotov
Added/Updated tests\bugs\core_4964_test.py: Expected ISQL output must…
b9ac702 
… be compared with filtered capsys.readouterr().out rather than with act.stdout. Noted by Dimitry Sibiryakov, #27
@pavel-zotov
Copy link
Contributor

Fixed, see notes in bugs/core_4964_test.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aafemt @pavel-zotov