Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --username and --password required in deployer #6

Open
mrotteveel opened this issue Jun 11, 2016 · 2 comments
Open

Make --username and --password required in deployer #6

mrotteveel opened this issue Jun 11, 2016 · 2 comments

Comments

@mrotteveel
Copy link
Member

The username and password are optional in deployer, consider making them required (or at minimum display a warning when left off). I was trying to install fbjava, and I had made a typo in the --password option (I typed --pasword instead) and it took me a while to notice that typo ;).
@asfernandes
Copy link
Member

@mrotteveel but it's valid in FB 3 to not use them.

@mrotteveel
Copy link
Member Author

Maybe then display a warning for unrecognized options and --username without --password (and vice versa)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asfernandes @mrotteveel