Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemRangeFix adds Unit as a parameter to range getters / GetItemDisplayRangeString #583

Open
Veslyquix opened this issue Feb 7, 2024 · 0 comments
Open

ItemRangeFix adds Unit as a parameter to range getters / GetItemDisplayRangeString #583

Veslyquix opened this issue Feb 7, 2024 · 0 comments
Labels
Core Features Issues pertaining to the core functions of the Skill System, its skills, or its dependencies. Enhancement Issues that suggest new and/or improved features.

Comments

@Veslyquix
Copy link
Contributor

Any hack that uses GetItemDisplayRangeString must put unit into 0x02003BFC+0x0C.
https://github.com/FireEmblemUniverse/SkillSystem_FE8/blob/master/EngineHacks/Necessary/ItemRangeFix/ItemRangeFix.event#L256
https://github.com/FireEmblemUniverse/SkillSystem_FE8/blob/master/EngineHacks/Necessary/ItemRangeFix/RangeTextDisplay/StatScreenRange.s#L17

I think adding parameters to vanilla functions is not advisable. Instead, a copy of the function from the decomp should be made and called as desired.
@sme23 sme23 added the Enhancement Issues that suggest new and/or improved features. label Feb 15, 2024
@sme23 sme23 added the Core Features Issues pertaining to the core functions of the Skill System, its skills, or its dependencies. label Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core Features Issues pertaining to the core functions of the Skill System, its skills, or its dependencies. Enhancement Issues that suggest new and/or improved features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sme23 @Veslyquix