Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gotcha with git (windows) #8

Open
code-mc opened this issue Apr 4, 2018 · 0 comments
Open

Gotcha with git (windows) #8

code-mc opened this issue Apr 4, 2018 · 0 comments

Comments

@code-mc
Copy link

code-mc commented Apr 4, 2018

I thoroughly read the readme and stumbled upon the section that warns for saving the file in a file editor or using version control which could change the line endings. This unfortunately happens on git (windows) with the default settings, and really got me scratching my head when it suddenly stopped working.

The issue however is that git only converts the file in its internal storage and leaves the unmodified file behind on disk, so it's only after you clone the repo that the file with the modified line endings is pulled.

Adding a warning for this in the readme might be helpful for other people. The solution for me was adding a .gitattributes file with following contents:

# never convert line endings of license files
*.key.lic -crlf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant