Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdf2htmlEX extensions #434

Open
btbonval opened this issue Jun 15, 2015 · 3 comments
Open

pdf2htmlEX extensions #434

btbonval opened this issue Jun 15, 2015 · 3 comments
Assignees
Labels

Comments

@btbonval
Copy link
Member

Do we still need pdf2htmlEX?

If so, do we still need those two pdf2htmlEX extensions which patch the upstream source?

Presently the documentation assumes we still need it and the patching is still required. Changes were made that might invalidate one or both assumptions.

@btbonval btbonval self-assigned this Jun 15, 2015
@AndrewMagliozzi
Copy link
Member

Yes we still need this. Not sure about the two extensions, however.

On Jun 14, 2015, at 9:42 PM, Bryan Bonvallet notifications@github.com wrote:

Do we still need pdf2htmlEX?

If so, do we still need those two pdf2htmlEX extensions which patch the upstream source?

Presently the documentation assumes we still need it and the patching is still required. Changes were made that might invalidate one or both assumptions.


Reply to this email directly or view it on GitHub.

@btbonval
Copy link
Member Author

I believe the extensions were exposed for the PDF viewer with the zoom buttons and chapter selection. I think @yourcelf made a universal zoom with CSS which worked even on the PDF pages, and I'm not sure if we support chapters now (we were going to support global chapters somehow).

I'll have to look at the code to know for sure. If it happened as I remembered, we no longer need a patched version of pdf2htmlEX, which will streamline the bootstrap process ever so slightly.

@AndrewMagliozzi
Copy link
Member

cool

On Mon, Jun 15, 2015 at 11:05 AM, Bryan Bonvallet notifications@github.com
wrote:

I believe the extensions were exposed for the PDF viewer with the zoom
buttons and chapter selection. I think @yourcelf
https://github.com/yourcelf made a universal zoom with CSS which worked
even on the PDF pages, and I'm not sure if we support chapters now (we were
going to support global chapters somehow).

I'll have to look at the code to know for sure. If it happened as I
remembered, we no longer need a patched version of pdf2htmlEX, which will
streamline the bootstrap process ever so slightly.


Reply to this email directly or view it on GitHub
#434 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants