Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin panel should inherit from moderator panel #268

Open
btbonval opened this issue Jan 10, 2014 · 3 comments
Open

admin panel should inherit from moderator panel #268

btbonval opened this issue Jan 10, 2014 · 3 comments

Comments

@btbonval
Copy link
Member

Right now the moderator panel is pretty slick, while the admin panel is weak sauce.

It'd be great if the admin panel inherited all the moderator panel functionality so it was at least as slick.

@AndrewMagliozzi
Copy link
Member

Yes!

On Jan 10, 2014, at 5:15 PM, Bryan Bonvallet [email protected] wrote:

Right now the moderator panel is pretty slick, while the admin panel is weak sauce.

It'd be great if the admin panel inherited all the moderator panel functionality so it was at least as slick.


Reply to this email directly or view it on GitHub.

@ghost ghost assigned btbonval Jan 20, 2014
@btbonval
Copy link
Member Author

btbonval commented Apr 4, 2014

The moderator interface will still be needed as it represents a reduced privilege set.

The right way to do this is to pull the admin definitions out of moderator/admin.py and place them into the respective <collection>/admin.py files with expanded privileges.

I initially thought inheriting from moderator would be an easy way to keep these definitions centralized, but moderator/admin.py already imports from <collection>/admin.py files. Circular dependencies are circular. Best to put it in the right spot from the start.

@btbonval btbonval removed their assignment Dec 2, 2014
@btbonval btbonval removed this from the Moderation milestone Jan 26, 2015
@btbonval btbonval added bug and removed enhancement labels Jan 26, 2015
@btbonval
Copy link
Member Author

It seems like the admin interface is blocking capabilities that should exist, making this a bug rather than an enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants