Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Pipeline > Selecting node doesn't add, and Create button should be disabled #65

Open
ljsinclair opened this issue Nov 15, 2023 · 0 comments

Comments

@ljsinclair
Copy link

ljsinclair commented Nov 15, 2023

Issues

  1. The field title "Add node" implies what's selected will be added (making the Add button redundant)
  2. The "Create" button is enabled which means just selecting a node then clicking throws an error (which contains typos)

Steps to reproduce

  • Create a template using the Getting Started key/values
  • Create a node using the Getting started template
  • Name the pipeline
  • Choose a node
  • Click Create

Result: Error message with typos -- "The request body must be valid JSON data and contain a 'name' and 'nodess' key"

Solution

  • Change the field title to "Add nodes"
  • Add field comment: "Add as many nodes as required"
  • Move the ADD button to beside the Create and Close buttons because it makes what will occur more obvious to new users
  • Rename ADD to ADD NODE
  • Enable ADD NODE button ONLY after a node is selected
  • Enable Create AFTER the user clicks ADD
  • Enable Close at all times (although I'd suggest "Cancel" would be better as "close implies what's there will remain".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant