Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lotsa Stuff #14

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Lotsa Stuff #14

wants to merge 5 commits into from

Conversation

mimoduo
Copy link

@mimoduo mimoduo commented Jan 8, 2019

Tim!

I made a bunch of markup consistency updates and paired down the css to make it easier to style.

I tested by live injecting the stylesheet onto a sample Monticello form with all the fields set to required and added additional copied fields with the respective different options. So the changes may need some extra love afterwards.

Sincerely,
Bryan Stoner

@mimoduo mimoduo requested a review from timbuckingham January 8, 2019 16:45
@timbuckingham
Copy link
Collaborator

I think I'm down with all these changes but we can't move them into the mainline Form Builder extension because they're a huge backwards compatibility break with any existing site that counts on the old markup / CSS styling being the same.

I think we might want to merge this into something like Form Builder 2 (like we did for Events when we broke backwards compatibility). Maybe we can add in some fancy feature like conditional fields into that as well if we have time.

@mimoduo
Copy link
Author

mimoduo commented Jan 10, 2019

Sounds good to me!

There are a few other areas I'd like to touch up on like required field support.
Conditional fields sound awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants