-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer shows above header #10
Comments
@tim93422 thanks for the report. What step of the lesson is this on? |
Steps:
I also followed the tutorial up to the point where you add the Footer and NavButtons and got the same result. It appeared that the setAlign(0,1) wasn't having the desired result, but I don't understand how it all works so you are probably best just checking it out on your own. |
Thanks for the heads up, I will take a look at it. |
@tim93422 Can you look at the styles and confirm that the html and body elements have height of 100%? |
@tim93422 Thank you very much for looking into this. |
Thank you and Michael for looking into it. I never would have figured it |
Hmm... 14 days later there's still some sort of issue going on. Took me a long time looking through the tutorial before finally checking over here on Github and finding this issue. Adding the CSS mentioned above fixed it, but just fyi this is still broken when a user initially pulls the tutorial down from the CLI. |
@Morgantheplant @wgester can you work on getting this fixed in production please |
The Footer shows up above the Header. The buttons are very tiny. This occurs when forked and run "as-is" on MacOSX w/ Safari and Firefox and when forked and run "as-is" from Ubuntu w/ Firefox.
The text was updated successfully, but these errors were encountered: