Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs with the same subdomain are in two separated groups #5

Open
elchn opened this issue Jan 16, 2024 · 1 comment
Open

Tabs with the same subdomain are in two separated groups #5

elchn opened this issue Jan 16, 2024 · 1 comment

Comments

@elchn
Copy link

elchn commented Jan 16, 2024

Thanks for your work.It's really the extension that I was expecting.
Would you mind adding a new feature to auto putting all tabs with the same domain into a single group? It seemed that two groups with the same domain appeared
image

image

@FaisalBinAhmed
Copy link
Owner

Hi @elchn
Thanks for opening the issue.
I just noticed this today, otherwise would have replied earlier.

While this is certainly doable, I think this still might be a niche edge case.
This happens when a new tab group is created from a tab that was previously not part of a tab group. In your case there was a tab group already with the same group.

What you are describing is merging tab groups. In order to do so: you have to do calculation on each tab creation and loop through existing groups to check their origin tab's domain.

For such use case, I think it's not worth the performance penalty. But if more people request, I might revisit this. :)

I wish you a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants