Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPA Admission Controller Hooks Multiarch Image #854

Open
jordanfelle opened this issue Jul 1, 2022 · 3 comments
Open

VPA Admission Controller Hooks Multiarch Image #854

jordanfelle opened this issue Jul 1, 2022 · 3 comments
Labels
enhancement Adding additional functionality or improvements pinned Prevents stalebot from removing

Comments

@jordanfelle
Copy link

Is your feature request related to a problem? Please describe.
Running the VPA on an ARM64 only cluster fails if Admission Controller is enabled

Describe the solution you'd like
Switch to a multiarch image that will let the helm chart work in arm64 only clusters

@sudermanjr
Copy link
Member

Is there a publicly available multi-arch image available? I would be happy to accept a PR to change the image. We don't maintain the VPA project, so I don't control what images are available by default, and maintaining a pipeline to build new ones is a bit out of scope for us at the moment.

@jordanfelle
Copy link
Author

@sudermanjr Sorry, I should have specified the image that is the problem. The VPA images are multiarch and it looks like the only image that isn't is one that is not part of the official VPA images at https://github.com/FairwindsOps/charts/blob/master/stable/vpa/values.yaml#L135 . Looking at it on quay the layers look like they are setup to be built for mutliarch but only the amd64 was pushed up.

@sudermanjr
Copy link
Member

Ahhh, I see. Yeah, that's one of our images. I don't see us moving that particular one to be multiarch due to the process being much much older.

I think we could probably swap that out. We only used it for convenience at the time.

@sudermanjr sudermanjr changed the title VPA Admission Controller Multiarch VPA Admission Controller Hooks Multiarch Image Jul 7, 2022
@sudermanjr sudermanjr added the enhancement Adding additional functionality or improvements label Jul 7, 2022
@sudermanjr sudermanjr added the pinned Prevents stalebot from removing label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements pinned Prevents stalebot from removing
Projects
None yet
Development

No branches or pull requests

2 participants