Possible texture memory leak

[yuna0x0]

Is it normal that texture memory won't be released after back to the main menu?

My gamemode will be using a lot of texture memory due to #2667 where I can't release the texture (the texture can't be used anymore after Dispose()).
But I expect s&box to release texture memory after the user exit my gamemode and back to the main menu. Otherwise, the user will have to restart s&box to play normally.

[handsomematt]

Does this only happen when you try to Dispose() your textures manually

[yuna0x0]

No, it is the opposite.
This happens when I do not Dispose() my textures manually.

My gamemode code is doing something that looks like this:

using Sandbox;

namespace edisonlee55.MyGameMode;

[SceneCamera.AutomaticRenderHook]
internal class RenderHook : Sandbox.RenderHook
{
	public RenderAttributes renderAttributes = new();
	public int frame = 0;

	// ...

	public override void OnFrame(SceneCamera target)
	{
		var texture = Texture.Load(FileSystem.Mounted, $"textures/{frame}.jpg");
		renderAttributes.Set("Texture", texture);
		frame++;
	}

	// ...
}

[handsomematt]

So you're loading how many different textures exactly.. 1000? 10000?

[yuna0x0]

About 6500 different textures in total.
The texture will be only used once in that frame and should be garbage collected after that frame.
(screenshot above only have loaded about 1000 textures.)

[yuna0x0]

The leak can be reproduced in my gamemode Bad Apple!!
The resource won't release when going back to the main menu.

After loaded 6572 different textures:

[yuna0x0]

This issue is fixed in a recent commit (sbox/master#de6f8f). Thank you! (´• ω •`)