Addons + Razor + New Menu

[garrynewman]

Just merging this in, headline changes

• Menu has been changed around a bit
• Can create addons and addons that target specific games
• Added Razor ui
• Compile notification options
• New panel inspector/selector

Addons

This is the first iteration of this system, and therefore it's quite basic. It's a babystep. Right now you can only enable and disable addons before creating the game.

You can make an addon that will target all gamemodes (and therefore only reference base), or you can target a specific gamemode (and it'll download that gamemode so you can target it).

Razor

The razor implementation does its best to work with intellisense, and for the most part it gets it right. It would be nice if it detected and autocompleted class names when adding elements. It might be something that we have to look at making our own VS extension for in the future (if that's even possible).

If you don't really know what razor is, imagine the html templates we have now but you can also run code and do logic in them.

It is my feeling that this is a much more sensible way of doing the UI and we will over the next few months dismantle and remove the old html template system.

New Menu

The new menu wasn't really planned, it was a necessity of the addon system. So stuff is kind of all over the place. Please shout out if something is fucked.

Lots of changes

I changed a lot under the hood to get this all done, so I am expecting some things to have become broken. Please let me know in this thread or with an issue and I'll get on it asap.

[Xenthio]

issue when trying to load shishkabob.hls2

[handsomematt]

Should work after update

[MuffinTastic]

Menu issue - when changing the lobby from one game to another one that's limited to a single map, the lobby's map setting isn't reset for the new game

sbox-dev_xuCtyNaAmC.mp4

[MuffinTastic]

Moved to #2451

[cherryymerryy]

Appeared when entering the game

[handsomematt]

Delete your addons/menu folder and verify your game files, this is very likely caused by you having old files still.

[cherryymerryy]

it helped
thanks

[notmatical]

In both of these screenshots, the highlighted components seems to intrude on the components in the settings tabs

Not sure if this is an intentional change, but the padding on your local addons page seems "tight"

[MrBrawls]

Launching via Sandbox brings up a Coding Error

console brought up these errors

[handsomematt]

Was this launching a local game in non-tools mode? Cause that should be fixed now

[MrBrawls]

yes it was in non-tool mode, and I just tested it now and it works from the update earlier.

[Xenthio]

after making an addon i cannot load my game anymore until i delete the addon

[MuffinTastic]

(and it'll download that gamemode so you can target it)

This doesn't seem to happen. I try to set the addon's parent ident like so and when I click save I get an exception

When I download facepunch.sandbox's repo separately, it works just fine.

[handsomematt]

Might be fixed now

[MuffinTastic]

Fixed

[MuffinTastic]

My addon compiles and works ingame, but while trying to upload it to the backend I get this. I'd show a more complete stack trace but no exceptions show up in the console

Funky chars in the path don't seem to matter, it fails when stored at C:\Users\Muffin\Documents\sandbox_tool_poc\code as well. I think it purely has to do with the fact that it's targeting a game.

Here's the addon, I'm not doing anything fancy
sandbox_tool_poc.zip

[gvarados1]

Yeah I'm getting the same thing, "Sequence contains no matching element"
Only happens when I target a specific game (facepunch.sandbox)

[handsomematt]

Should be fixed now

[MuffinTastic]

Fixed, looks like you got two birds with one stone

[MuffinTastic]

It would be nice to be able to see local addons that are enabled in this list in the lobby menu, 1. for the sake of clarity and 2. so we could preview/test the local addon's convar UI

[FarikLoL]

[jtmckay2017]

Trying to load into my game (Simple Slots) when not in editor mode and getting Couldn't find base.dll
Not sure what other information to provide for this as I am able to load in fine in editor mode. And don't see anything else in logs. Thanks!

[handsomematt]

Should be good after next update

[jtmckay2017]

Cool, I'll check it out once the builds uploaded and let you know

[jtmckay2017]

@handsomematt Fixed, thank you sir.

[BlockBuilder57]

Incredibly critical bug: the main menu citizen doesn't get scared of the quit button anymore

[MuffinTastic]

After the latest update (I think - build 2191f3) with a locally enabled addon targeting facepunch.sandbox, I get this now while starting a game (the rest of the game loads as normal, just the addon gets screwed)

If this has to do with the legacy assembly stuff again maybe it's best to reupload sandbox lol

[handsomematt]

Ah I didn't have code that was directly referencing - I'll give it a go in the morning if Garry doesn't beat me to it.
Thanks for being so thorough it's a great help. :)

[trende2001]

was happening to me as well, thanks to you for reporting this

[garrynewman]

This bug (local gamemode vs packaged addons) should be fixed now. The only thing I would say is that things might get weird when hotloading right now.

[MuffinTastic]

Unless you mistyped I think you have it backwards, this is packaged gamemode w/ local addons.

In any case, sadly it's still not working, but I'm getting a new error now. Build ff037c

Also seems to be the direct cause of a fun little bonus error in the compile notice, so I'll throw this in here too

[MuffinTastic]

This is still a thing, but I'm actually gonna move all the current problems I've hit (including this one) into their own issues. I figure it'll be easier for you guys to track

Here's the one for this bug #2449

[FarikLoL]

settings by type server name, number of players, etc. are not saved.

[MuffinTastic]

After recent changes, if a local addon fails to compile and one leaves a packaged game without fixing it, it will "remember" that failed compile and won't try to compile it again. This state sticks around for the remainder of the session, even if you disable the addon in question, and makes games refuse to start, booting you out with the Coding Error popup.

I'll give two repros for this, I'm pretty confident they're the exact same thing, but just in case.

• Failed compile during hotload

  1. Start s&box
  2. Create a new addon. It doesn't have to target anything. Make sure it's enabled and all that
  3. Add some valid code to the addon - e.g. a new empty class
  4. Start a packaged game. Doesn't matter which one, as long as it's not local. The addon will work here
  5. While in-game, edit the addon's code and make it invalid - e.g. remove a curly brace. It will try to hotload the now broken code
  6. After it's done, disconnect from the game
  7. Try starting another packaged game and you'll be booted out. Doesn't have to be the same one
  8. Try fixing the addon code, it will still boot you
  9. Try disabling the addon, it will still boot you

• Failed compile at the start of the game

  1. Start s&box
  2. Create a new addon
  3. Add invalid code
  4. Start a packaged game. The game will work, the addon won't
  5. Immediately disconnect
  6. Try starting another packaged game, get booted
  7. Try fixing the addon, try disabling it, still get booted

Build ff037c

[MuffinTastic]

Copied/moved to a dedicated issue #2450

[MuffinTastic]

Build 2e1815, starting a packaged game (facepunch.sandbox). Doesn't matter if there are addons or not

[MuffinTastic]

Related issue #2444

[MuffinTastic]

Fixed on my end

[Fortune117]

Having used Razor quite a bit now, I find myself running into the same problem over and over in that references aren't set immediately when dynamically creating UI in code. I can't remember if that was the case with HTML templates, but it's resulting in a lot of boiler plate code that's quite tedious.