Incoming Refactor

[garrynewman]

I'm doing a big refactor of the physics and sceneobject APIs. This is going to be a breaking change and I'm going to make the game automatically hide older engine version games when I make it live.. so it'll be empty until people fix their addons and re-upload.

I did start doing this as a non breaking change, with lots of obsoletes. This would have worked fine, and I expect this to be one of the few version++ refactors we see, but I decided that this is the time for the bold changes.

Question 1

Are there any APIs that anyone can think of that could be cleaned up, or have been succeeded in some way and are now redundant?

Question 2

Which do you prefer?

PhysicsWorld world = new PhysicsWorld();
PhysicsBody body = world.AddBody();
SceneObject obj = new SceneModel();

or

Physics.World world = new Physics.World();
Physics.Body body = world.AddBody();
Scene.Object obj = new Scene.Model();

[trundlr]

I vastly prefer the first of the two code samples

[OpenSauce04]

I don't really have a strong preference for question 2, however is there is a large amount of things with the same prefix, the 2nd one would make more logical sense.
Otherwise it's whatever

[TheMoogle]

I'd say the first one seems more natural

[Dimak25]

If there are a lot of classes related to Physics namespace, then I would take the second type of writing code.

[NotGaylien]

i agree with this, it makes sense to do
Physics.World Physics.Body Physics.abc Physics.bca Physics.SoOn...
if there are more than like 5 things in them or something.
but if its litteraly just the one PhysicsWorld, PhysicsBody then the 2nd is much more preferable, since it looks tidier.

[Sampleeeee]

I also completely agree with this

[OpenSauce04]

I'd say that this would definitely be better if and only if there is a lot of them; Say >5

[Sampleeeee]

He showed this screenshot on a thread in discord.

I think it would be a lot nicer with the second option

Also I think it should be Scene.Spotlight because spotlight is one word not two

[rayandu924]

Full agree me too

[GGG-KILLER]

For question 2 I'd say go with the 2nd and if people want the 1st they can use <Using> to alias it:

    <Using Include="Sandbox.Physics.World" Alias="PhysicsWorld" />
    <Using Include="Sandbox.Physics.Body" Alias="PhysicsBody" />
    <Using Include="Sandbox.Scene.Object" Alias="SceneObject" />

1st would be bad as the inverse is not possible.

[Bagelboi]

Based

[SneakySquid]

Based

[itz-coffee]

Based

[AlexVeeBee]

Based

[ZehMatt]

Second version, seems logical to split modules and all of what they have by namespaces. I would even prefer to have it Rendering.Scene.Object