PlayerScore obsolete

[garrynewman]

PlayerScore - which was used by the scoreboard to store/retrieve player score variables - is now obsolete.

We can just use Client now for the same purpose. They're always transmitted.

Scoreboard works pretty much the same except anything with PlayerScore is obsolete now.

[Alf21]

When setting a shared/broadcasted int var on the client via Client.SetInt(key, value), I have to track changes as well.

How can I do this? Currently, I'm using Client.SetInt(key, value) on the server and then running a ClientRPC to update e.g. the Scoreboard (https://github.com/TTTReborn/tttreborn/pull/243/files#diff-c7b472d41a30a26d5c787a0f1b87c28cade0b8f59e2c7cae3ea99e836338b320R224-R234). There, I don't know whether it's reliable, whether the SetInt broadcast change will appear before the ClientRPC.

That said, a change callback would be great (like PlayerScore.OnUpdate has been).

Additionally, currently we are just able to sync int. Is SetValue the same, but with the possibility to add string or especially bool?

[garrynewman]

You should be able to SetValue strings and bools etc. Are you saying that doesn't work?

Do you want to get a change callback so you can change the value on the scoreboard? Are you having problems if you just set it every frame in Tick?

[Alf21]

No, I didn't tested SetValue, as int are currently enough (even that I'm syncing a bool via SetInt, gonna change this later). If it doesn't work, I gonna open an issue.

Exactly. Currently, when changing a value, I trigger a ClientRPC to apply the connected changes to the scoreboard. Personally, based on performance reasons and upcoming scaling, I avoid doinf stuff every tick. You are right, if I would just use Tick to update the scoreboard regarding the GetInt value, I wouldn't need a callback.

[garrynewman]

You shouldn't have any performance problems updating the row every tick. The labels are designed in a way that they won't invalidate if you're setting the text to the same value it already is.

[Alf21]

Thanks for the hint. Currently, based on the GetInt data, I'm not just updating labels, but the whole Scoreboard (forced spectator bool, that moves the player into another scoreboard group and restructures the scoreboard). I can do like you suggested, which would require to create a private value that keeps track of the old GetInt value to detect changes and to trigger the scoreboard update.

A callback would avoid that workaround, but I don't have a problem doing so if you think it's not worth the work :)

// edit: That would be the workaround: TTTReborn/tttreborn@e091acd#diff-db4fc010b1105678ab5a8d2145c27ea860230ef7f5581599143e77cda333a97cR172-R188 (just to call UpdateClient(client))