Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkboxes and action buttons in lists #2187

Open
ikabod opened this issue Feb 9, 2020 · 0 comments
Open

Checkboxes and action buttons in lists #2187

ikabod opened this issue Feb 9, 2020 · 0 comments

Comments

@ikabod
Copy link

ikabod commented Feb 9, 2020

There are some problems with checkboxes and action buttons in lists:

  1. If you click on the delete button in a row, it makes no sense to force an checked checkbox, since the user will be ask anyway if he want to delete the row.

  2. If you activate in the list settings under "Links" the option "Hide checkbox" you can not use anymore the delete button(s) and custom action buttons with activated "Require Checked" option.

  3. In the action butons "View" and "Edit" the row id is given (e. g. data-rowid="19"). This is missing in the delete buttons and in custom action buttons, that requires a checked row. So it makes no sense to deactivate the "Require Checked" option in custom action buttons (list plugin php), since the php code has no access to the rowid.

Suggestions:

  1. Remove the require select row message on the delete button in the rows.

  2. Add the data-rowid attribute to all buttons in a row to be able to access the row id in php code without a checked checkbox.

  3. When the option "Hide checkbox" is activated, the delete Icon in the header should ask the user: "Do you really want to delete all listed items?" (or similar). Same for custom action buttons in the header ("Do you really want to process all listed items with action "X"?) X = Button label.

  4. Add an option "Button in header" since it sometimes makes sence to run an action only on the current row, not on multiple selected rows.

  5. I was confused trying to make changes on the template files, which have a "button" in the name, because they do not effect any buttons, but only links. Please make the rendering of the action buttons available as a templete too. I want to show different icons for different states of an item, so I can use the same button to toggle an action without adding a second button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant