Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata of downloaded files incomplete #1376

Open
dickscheid opened this issue Jul 5, 2023 · 3 comments
Open

Metadata of downloaded files incomplete #1376

dickscheid opened this issue Jul 5, 2023 · 3 comments
Labels

Comments

@dickscheid
Copy link
Collaborator

When downloading parcellation maps from the web application, the download folder contains markdown and text files with too little information:

  • description missing
  • license missing
  • citation missing
  • sometimes link to online resource missing (e.g. knowledge graph dataset link)
@dickscheid
Copy link
Collaborator Author

Related comments:

  • I suggest to merge all metadata into the README instead of shipping one markdown file per downloaded file. The readme should describe all files in the downloaded package.
  • When downloading a probability, I would not include the maxprobmap as.a NIfTI. The package should just provide what the user saw in the view - the template, the probability map.

@xgui3783
Copy link
Member

xgui3783 commented Jul 5, 2023

siibra-explorer uses space/parcellation's description and publication properties to popuate description and citation.[1] If they are missing in the download bundle, that means it is missing in siibra-python.

We will fix this issue at relevant places ASAP.

License is completely missing, yes. We are aware of the issue and will address it ASAP.

sometimes link to online resource missing (e.g. knowledge graph dataset link)

We are already aware of this issue, and a fix is on the way.

I suggest to merge all metadata into the README instead of shipping one markdown file per downloaded file. The readme should describe all files in the downloaded package.

When downloading a probability, I would not include the maxprobmap as.a NIfTI. The package should just provide what the user saw in the view - the template, the probability map.

We will see to it that these to be done.

[1] https://github.com/FZJ-INM1-BDA/siibra-api/blob/v0.3.10/api/common/data_handlers/compounds/download.py#L58-L68

@xgui3783
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants