Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve feature files #27

Open
gabiudrescu opened this issue May 18, 2020 · 3 comments
Open

Improve feature files #27

gabiudrescu opened this issue May 18, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@gabiudrescu
Copy link

Although technically correct, the feature files are a bit confusing:

    @ui
    Scenario: Address an order with a country different from the VAT country number
        Given I have product "PHP T-Shirt" in the cart
        And I am at the checkout addressing step
        And I specify the shipping address as "Ankh Morpork", "Frost Alley", "90210", "United States" for "Jon Snow"
        And I specify the billing address as "Ankh Morpork", "Frost Alley", "90210", "United States" for "Eddard Stark"
        And I specify the shipping vat number as "FR01234567891"
        And I specify the billing vat number as "FR01234567891"
        And I try to complete the addressing step
        Then I should be notified that the vat number in shipping details is not corresponding with the selected country
        And I should be notified that the vat number in billing details is not corresponding with the selected country

this one is using the same address as the one below, but both are invalid:

    @ui
    Scenario: Address an order with a country different from the VAT country number
        Given I have product "PHP T-Shirt" in the cart
        And I am at the checkout addressing step
        And I specify the shipping address as "Ankh Morpork", "Frost Alley", "90210", "France" for "Jon Snow"
        And I specify the billing address as "Ankh Morpork", "Frost Alley", "90210", "France" for "Eddard Stark"
        And I specify the shipping vat number as "FR01234567891"
        And I specify the billing vat number as "FR01234567891"
        And I try to complete the addressing step
        And I should be notified that the vat number in shipping details is not valid
        And I should be notified that the vat number in billing details is not valid

there is no feature for valid scenario and no feature with full checkout process.

nor how it looks in admin or myAccount.

to my personal taste, I would use here valid France addresses (and why, not maybe even French hero names 😀 )

@Prometee Prometee added the enhancement New feature or request label May 18, 2020
@Prometee
Copy link
Member

This was my first try with Behat and I already put a task to enhance it don't worry, I just need some time to rewrite them.

@gabiudrescu
Copy link
Author

I have analysed the solution you provide with this plugin and I though it would be useful for you (and others) to address questions / improvements in issues, in a more official way.

hope it helps.

if we decide to work with your plugin, are you open to PRs to implement such feedback?

@Prometee
Copy link
Member

Yes of course !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants