Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found a code security issue in function “encode_load_input_images” #539

Open
xiaolian8325 opened this issue Jul 8, 2019 · 0 comments

Comments

@xiaolian8325
Copy link

hi,

issue

the function snprintf use an external and controllable argument like argv[0], that is very dangerous. Because the argument is just a format string, it contains some symbols as %n %p %s are very dangerous. The user can read or write the stack segment by using them.

code

             snprintf(filename,maxlength,argv[0],framecounter);
             if (!file_exists(filename)) {
                stop_searching++;
                continue;
             }

example

use the command
./flif -e sig%s.%s.png test.flif
the error will be
Segmentation fault

thanks for your time.

from: Eagleye team
Cheng Renfeng. Zhou Kai. Cheng Xiaoyan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant