Retrieving all Entity Types only returns the Types of the first 20 elements.

[cfreyfh]

When retrieving all Entity Types through the endpoint /ngsi-ld/v1/types there is a problem with the backend:

In the MongoDB query function

context.Orion-LD/src/lib/orionld/mongoc/mongocEntitiesGet.cpp

Line 60 in 659de32

int limit = orionldState.uriParams.limit;

the URL parameters limit and offset are used for the query.

The first problem is that it is not allowed to pass the limit and offset parameters to that endpoint.

{
    "type": "https://uri.etsi.org/ngsi-ld/errors/BadRequestData",
    "title": "Unsupported URI parameter",
    "detail": "limit"
}

So only the first 20 (the default value for limit) elements are returned from the MongoDB and only the types from these entities are returned. Even if the URL parameters would be allowed, I think it makes no sense to use them in that way since the behaviour of the two parameters would be not as intended.

[kzangeli]

Ok, noted.
Seems like a very silly bug!
Thanks for finding it.
I should have a fix real soon.

[kzangeli]

So, you are right in everything you say.
Seems like I was thinking of something else when I implemented this. Makers zero sense.
I'll have to rewrite the whole thing.
BUT, no time for that right now, so I'll do a quick and dirty thing that at least makes you able to extract all types, with pagination, even though the limit/offset are on entities and not entity types:

1. Allow limit/offset
2. Set default limit to 1000 (unless set to anything else by the user)

So, in a first request you get one batch of entity types (only God knows how many).
In the next "paginated" request (offset=1000) you get a second batch (might get entity types from batch 1).

Quite bad, sorry, but at least much better than it was.

We will not close this issue until I've rewritten the whole thing.

[kzangeli]

So, I think I got the library error fixed.
Please test again, using the tag 1.8.0-PRE-1640 in dockerhub.

Remember it's not really fixed, just the dirty hack that I described earlier.

[cfreyfh]

Thank you, now we can get all the types as we need :-)