Skip to content

Latest commit

 

History

History
87 lines (48 loc) · 5.01 KB

Icons.md

File metadata and controls

87 lines (48 loc) · 5.01 KB
Raw

Icon Sourcing

If you come across an icon used in the designs, its almost certainly a Nala icon. In the design, you should be able to see the name of the icon to use in the properties panel:

image

Depending on where the icon is used, there are a couple of different strategies for using the icon:

WebUI

Add the icon to the leo_icons array in brave/ui/webui/resources/BUILD.gn. The icon will be available at chrome://resources/brave-icons/<name>. The easiest way to display it is via the leo-icon component:

// React
import Icon from '@brave/leo/react/icon`

<Icon name="<name>"/>


// Polymer/Lit
<leo-icon name="<name>"></leo-icon>

If you're creating a new WebUI page, you'll also need to set the icon base path, so Nala knows where to find the icons:

// At some point early on:
import { setIconBasePath } from '@brave/leo/react/icon'
setIconBasePath('//resources/brave-icons')

Brave Views

To make a Nala icon available in views, add the name of the icon to the leo_icons array in brave/components/vector_icons/BUILD.gn. The name of icons are transformed slightly, to make them usable by the aggregate_vector_icons script. Dashes are replaced with underscores, and leo is prefixed to the icon, so carat-right.svg becomes leo_carat_right.svg. The icon will be available in the C++ as kLeoCaratRightIcon.

Chromium Views

Sometimes, we just want to replace a Chromium icon. The easiest way to do this is to add the icon we want to replace to the brave/vector_icons/leo_overrides.json file. Add the path of the icon you want to replace and point it at the name of the Nala icon to use.

Note: Sometimes, where Chromium doesn't provide an explicit size for the icon the icon size will be wrong, so it's worth checking this. @zenparsing had some ideas about how we could fix this, but we haven't got around to it yet.

My use case isn't covered / it doesn't work / my icon isn't available!

Reach out to @fallaciousreasoning or @petemill and hopefully one of us can get things working for you 😄

Previewing/Editing Icons

Icons can be previewed using the Skia Icon Preview Extension or online via the Skia Icon Editor.

Important Chromium Icon Documentation

The Chromium Icon Documentation is latest reference place to go for updating Icon files.

Sketch to SKIA Process

There is a process that seems pretty dependable in converting icons that are shapes to SKIA with minimal manual editing.

  1. Set the artboard size of an individual icon to the same size of the canvas in the icon you are replacing. This is very often 16, 24, or 32.

  2. Convert icons to 100% shapes and combine them. In order for this process to work, we can't have stroked elements within the svg or we will have to manually state the stroke size in Skia.

  3. Selecting the artboard (not the icon, the artboard), click Edit-> Copy SVG Code

  4. Using the SVGOMG cleaner, paste in our SVG code. I have toyed with these settings a bit and I'm unsure the absolute best combination but the one setting that is mandatory is to make sure the "Remove viewBox" setting is disabled. We need the viewbox declarations to create our canvas size in Skia.

  5. Copy the compressed SVG code, bring it to Skiafy and paste it in. Since we are typically designing to size, I leave my scale at 1.0 and click Skiafy. Your code should have a canvas declaration and varying degrees of Move/Close declarations:

CANVAS_DIMENSIONS, 32,
MOVE_TO, 27, 27,R_H_LINE_TO, -5,V_LINE_TO, 16.5f,R_ARC_TO, 1.5f, 1.5f, 0, 0, 0, -1.5f, -1.5f,R_H_LINE_TO, -8,R_ARC_TO, 1.5f, 1.5f, 0, 0, 0, -1.5f, 1.5f,V_LINE_TO, 27,H_LINE_TO, 6,V_LINE_TO, 12.83f,R_LINE_TO, 10.5f, -6.56f,LINE_TO, 27, 12.83f,V_LINE_TO, 27,
CLOSE,R_MOVE_TO, -13, 0,R_H_LINE_TO, 5,R_V_LINE_TO, -9,R_H_LINE_TO, -5,R_V_LINE_TO, 9,CLOSE,R_MOVE_TO, 14.59f, -16.71f,LINE_TO, 17.3f, 3.23f,R_ARC_TO, 1.5f, 1.5f, 0, 0, 0, -1.59f, 0,R_LINE_TO, -11.29f, 7.06f,ARC_TO, 2.98f, 2.98f, 0, 0, 0, 3, 12.83f,V_LINE_TO, 27.5f,CUBIC_TO, 3, 28.88f, 4.12f, 30, 5.5f, 30,R_H_LINE_TO, 22,R_CUBIC_TO, 1.38f, 0, 2.5f, -1.12f, 2.5f, -2.5f,V_LINE_TO, 12.83f,R_ARC_TO, 2.98f, 2.98f, 0, 0, 0, -1.41f, -2.54f,CLOSE

One bug that happens occasionally is an SVG will bring a <def> </def> bracket around the svg code. This will cause Skia to not render any coordinates. Deleting this bracket fixes the issue.

References

[1] https://chromium.googlesource.com/chromium/src/+/master/components/vector_icons/README.md

[2] https://github.com/evanstade/skiafy

[3] https://jakearchibald.github.io/svgomg/

[4] https://chromium.googlesource.com/chromium/src/+/master/ui/gfx/vector_icon_types.h#28