From 52c78085affee3414687c626ab2824f9ea1feccb Mon Sep 17 00:00:00 2001 From: lL1l1 <82986251+lL1l1@users.noreply.github.com> Date: Sun, 24 Nov 2024 00:48:14 -0800 Subject: [PATCH 1/4] Exclude treads from movement effects warning --- lua/sim/Unit.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lua/sim/Unit.lua b/lua/sim/Unit.lua index 25e7ec8768..6482b12186 100644 --- a/lua/sim/Unit.lua +++ b/lua/sim/Unit.lua @@ -3729,8 +3729,8 @@ Unit = ClassUnit(moho.unit_methods, IntelComponent, VeterancyComponent, DebugUni local effectTypeGroups = bpTable.Effects if not effectTypeGroups or (effectTypeGroups and (table.empty(effectTypeGroups))) then - -- warning isn't needed if this layer's table is used for Footfall or Contrails without terrain effects - if not bpTable.Footfall and not bpTable.Contrails then + -- warning isn't needed if this layer's table is used for Footfall or Contrails or Treads without terrain movement effects + if not bpTable.Footfall and not bpTable.Contrails and not bpTable.Treads then WARN('*No movement effect groups defined for unit ', repr(self.UnitId), ', Effect groups with bone lists must be defined to play movement effects. Add these to the Display.MovementEffects.', layer, '.Effects table in unit blueprint.') end return false From 845e89f28750e1292f65a00dcf3f7a60d7ea8d0b Mon Sep 17 00:00:00 2001 From: lL1l1 <82986251+lL1l1@users.noreply.github.com> Date: Sun, 24 Nov 2024 01:10:48 -0800 Subject: [PATCH 2/4] Fix Spearhead tread spacing --- units/XEL0306/XEL0306_unit.bp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/units/XEL0306/XEL0306_unit.bp b/units/XEL0306/XEL0306_unit.bp index 41b7881190..1125dd2a49 100644 --- a/units/XEL0306/XEL0306_unit.bp +++ b/units/XEL0306/XEL0306_unit.bp @@ -60,9 +60,9 @@ UnitBlueprint{ { BoneName = "XEL0306", TreadMarks = "tank_treads_albedo", - TreadMarksInterval = 0.6, + TreadMarksInterval = 0.4, TreadMarksSizeX = 1.3, - TreadMarksSizeZ = 1, + TreadMarksSizeZ = 1.12, TreadOffset = { 0, 0, 0 }, }, }, From 195bdb89d81d9fea8311ae063165ae88d75fd9fa Mon Sep 17 00:00:00 2001 From: lL1l1 <82986251+lL1l1@users.noreply.github.com> Date: Sun, 24 Nov 2024 01:12:56 -0800 Subject: [PATCH 3/4] Remove treads from URL0208 lua file they belong in bp not lua --- units/URL0208/URL0208_script.lua | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/units/URL0208/URL0208_script.lua b/units/URL0208/URL0208_script.lua index e7fa914efd..5b687b8ae6 100644 --- a/units/URL0208/URL0208_script.lua +++ b/units/URL0208/URL0208_script.lua @@ -11,16 +11,5 @@ local CConstructionUnit = import("/lua/cybranunits.lua").CConstructionUnit ---@class URL0208 : CConstructionUnit -URL0208 = ClassUnit(CConstructionUnit) { - Treads = { - ScrollTreads = true, - BoneName = 'URL0208', - TreadMarks = 'tank_treads_albedo', - TreadMarksSizeX = 0.65, - TreadMarksSizeZ = 0.4, - TreadMarksInterval = 0.3, - TreadOffset = { 0, 0, 0 }, - }, -} - -TypeClass = URL0208 \ No newline at end of file +URL0208 = ClassUnit(CConstructionUnit) {} +TypeClass = URL0208 From f281bf17e4b6ea1c4c4a1b2c12bc1bf490f98f42 Mon Sep 17 00:00:00 2001 From: lL1l1 <82986251+lL1l1@users.noreply.github.com> Date: Sun, 24 Nov 2024 01:20:20 -0800 Subject: [PATCH 4/4] Update fix.6436.md --- changelog/snippets/fix.6436.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog/snippets/fix.6436.md b/changelog/snippets/fix.6436.md index 17e12d25bb..a0bf7e437a 100644 --- a/changelog/snippets/fix.6436.md +++ b/changelog/snippets/fix.6436.md @@ -1 +1 @@ -- (#6436, #6480) Prevent the logging of an unecessary warning when certain units make landfall. +- (#6436, #6480, #6552) Prevent the logging of an unecessary warning when certain units make landfall.