Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify hotbuild keybind collision warning #6217

Merged
merged 3 commits into from
May 30, 2024

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented May 26, 2024

Issue

Hotbuild automatically assigns shift and alt modifiers for its hotbuild actions, and gives warnings if another action is already bound to that key. The warning is hard to understand because it didn't specify what hotbuild key the autogenerated modifier came from.

WARNING: Hotbuild key Alt-H is already bound to action "Toggle intel and shield" under "ORDERS" category

Description of the proposed changes

Add the other side of the key collision to the warning, and the resolution of the collision.

WARNING: Alt modifier for Hotbuild action "build shields + mobiles Shields & shield disruptors + shield boat" (H)  is already bound to action "Toggle intel and shield" (Alt-H)
WARNING: The Alt modifier of the Hotbuild action will not work!

Testing done on the proposed changes

Checked for errors in log when closing the keybindings menu (this is when the keybindings are auto generated).

Checklist

  • Changes are documented in the changelog for the next game version

@lL1l1 lL1l1 added the area: ui Anything to do with the User Interface of the Game label May 26, 2024
@MrRowey MrRowey merged commit 4b7d025 into FAForever:deploy/fafdevelop May 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Anything to do with the User Interface of the Game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants