Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbquery getData calls success callback even if error #36

Open
mattlub opened this issue Mar 31, 2017 · 0 comments
Open

dbquery getData calls success callback even if error #36

mattlub opened this issue Mar 31, 2017 · 0 comments
Assignees
@Suuuuha
Labels
addressed

Comments

@mattlub
Copy link
Member

mattlub commented Mar 31, 2017

on the following lines, the callback is called twice if there's an error

https://github.com/FACN1/week6-facn-hosers/blob/master/src/DBquery.js#L7
https://github.com/FACN1/week6-facn-hosers/blob/master/src/DBquery.js#L16
@Suuuuha Suuuuha self-assigned this Mar 31, 2017
Suuuuha added a commit that referenced this issue Mar 31, 2017
@Suuuuha
#36 fix cb function - success when error
e520e76
m4v15 added a commit that referenced this issue Mar 31, 2017
@m4v15
Merge pull request #44 from FACN1/fixcallback
80774f8 
#36 fix cb function - success when error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Suuuuha Suuuuha

Labels
addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattlub @philawsophizing @Suuuuha