Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(not merge this until at least Monday)add another switch to control #1036

Open
wants to merge 1 commit into
base: h3c-pike
Choose a base branch
from
Open

(not merge this until at least Monday)add another switch to control #1036

wants to merge 1 commit into from

Conversation

Niklaus-xie
Copy link
Contributor

No description provided.

@Niklaus-xie Niklaus-xie self-assigned this Nov 13, 2020
@Niklaus-xie Niklaus-xie changed the title add another switch to control (not merge this until at least Monday)add another switch to control Nov 13, 2020
@Niklaus-xie
add another switch to control
55566f0 
if getting db members or not. Need to set to
True if SY does not modify at last.
@Niklaus-xie Niklaus-xie force-pushed the h3c-pike-if-sy-not-modify branch from 7124133 to 55566f0 Compare November 13, 2020 14:04
zhaoqin-github
zhaoqin-github requested changes Nov 13, 2020
View reviewed changes
Copy link
Collaborator

@zhaoqin-github zhaoqin-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides batch adding, other operation also need to call this method. This config option will disable the optimization of all others.

If batch adding need it unique way to append member, it can write its own function and pass it via kwargs.

zhaoqin-github
zhaoqin-github requested changes Nov 13, 2020
View reviewed changes
Copy link
Collaborator

@zhaoqin-github zhaoqin-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another problem is that batch adding is never optimized, so that its service payload will include all listeners and all pools and member under the lb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoqin-github zhaoqin-github zhaoqin-github requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Niklaus-xie Niklaus-xie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Niklaus-xie @zhaoqin-github