Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtual server option "serverssl-use-sni" in "bigip_virtual_server" and "bigip_device_info" #2438

Open
gomesjj opened this issue Nov 17, 2024 · 5 comments
Labels
backlog Item logged internally enhancement PRs or Issues for basic feature requests for an existing module.

Comments

@gomesjj
Copy link
Contributor

gomesjj commented Nov 17, 2024

Is your feature request related to a problem? Please describe.

There's no option to set the 'serverssl-use-sni' option using the "bigip_virtual_server" module. The module "bigip_device_info" also doesn't report this option's state.

As a workaround I am using the "bigip_command" module (see below example), but that is not idempotent and a warning is generated to that effect.

Using:

- name: Set serverssl_use_sni value
  f5networks.f5_modules.bigip_command:
    provider: "{{ provider }}"
    chdir: "{{ partition | default('Common') }}"
    commands:
      - modify ltm virtual {{ vs_name }} serverssl-use-sni enabled
  delegate_to: localhost

Describe the solution you'd like

I would like the ability to use the "bigip_virtual_server" module to set the option.

Desired:

 - name: Set serverssl_use_sni value
   f5networks.f5_modules.bigip_virtual_server:
     provider: "{{ provider }}"
     name: "{{ vs_name }}"
     serverssl_use_sni: true
   delegate_to: localhost

Describe alternatives you've considered

I've been using the "bigip_command" module, and I've also tested with the F5 rest API. I am not in a position to use AS3.

Additional context

Issue #2391 (raised in Feb) with the same request, but was invalidated with a recommendation to use the "bigip_command" module. However, I believe an idempotent method should be used. Also note that issue #2419 was recently addressed, adding the "per_flow_request_access_policy" option, which could also be set via the "bigip_command" module.

I've patched the modules locally and both work correctly. I can raise a pull request and provide the simple modifications to the modules if required.

Changes to modules:

"bigip_virtual_server" - adding 30 lines
"bigip_device_info" - adding 15 lines

@gomesjj gomesjj added enhancement PRs or Issues for basic feature requests for an existing module. untriaged issue that needs an initial response from the developers labels Nov 17, 2024
@gomesjj gomesjj changed the title Add virtual-servers option "serverssl-use-sni" in "bigip_virtual_server" and "bigip_device_info" Add virtual server option "serverssl-use-sni" in "bigip_virtual_server" and "bigip_device_info" Nov 17, 2024
@pgouband
Copy link
Contributor

Hi @gomesjj,

Individuals or business entities who contribute to this project must complete and submit the F5 Contributor License Agreement to [email protected] prior to their code submission being included in this project.

@gomesjj
Copy link
Contributor Author

gomesjj commented Nov 19, 2024

@pgouband,

I've sent the license agreement, although I think the changes are so minimal that I don't count it as proper contribution...

Anyway, raised pull request #2439.

@gomesjj
Copy link
Contributor Author

gomesjj commented Nov 19, 2024

I've closed the previous pull request as I made a mistake and submitted the wrong changes. I will raise another one… Sorry.

@gomesjj
Copy link
Contributor Author

gomesjj commented Nov 19, 2024

New pull request raised: #2441.

@pgouband
Copy link
Contributor

Hi,

Thanks for reporting. Added to the backlog and internal tracking ID for this request is: INFRAANO-1706.

@pgouband pgouband added backlog Item logged internally and removed untriaged issue that needs an initial response from the developers labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Item logged internally enhancement PRs or Issues for basic feature requests for an existing module.
Projects
None yet
Development

No branches or pull requests

2 participants