-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CE Banners #31
Comments
Hi @xraver, Well the banner is from the CE version of Xen Orchestra and before 5.59 a patch was applied (I thought that it wasn't used from months ... and I see now that quilt was using it anyway). Out of the scope of this issue, Olivier Lambert from XOA team answer this question. I think it's fair to leave this banner as you can close it and it's a reminder that this version is the CE. But if a majority think otherwise, I may re-use the patch. Let me know here why it bother you so much. |
Hi thanks for your clarification.
I personally don't like the banner. i think is implicit in the usage of
this version (community edition) that you have explicitly indicated in the
name of your project.
In any case thanks for your work. I very appreciate your container.
Il giorno lun 18 mag 2020 alle ore 08:26 Ezka <[email protected]> ha
scritto:
… Hi @xraver <https://github.com/xraver>,
Well the banner is from the *CE version* of Xen Orchestra and before 5.59
a patch was applied (I thought that it wasn't used from months ... and I
see now that quilt was using it anyway).
Out of the scope of this issue
<#30 (comment)>,
Olivier Lambert from XOA team answer this question. I think it's fair to
leave this banner as you can close it and it's a reminder that this version
is the CE. But if a majority think otherwise, I may re-use the patch. Let
me know here why it bother you so much.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALJM7AYXXZJCKERYV7XVDRLRSDIKHANCNFSM4NCTLMWA>
.
|
@xraver why not closing it, then? Also, we'll probably add a cookie so it won't come just after a refresh. Does it sound reasonable to you? |
Hi, i've closed the issue after my previouse replay. |
Hi
With the latest version 5.59 at the login time and in the top of the page there are banners related to the community edition (This version is not bundled with any support nor updates. Use it with caution.).
It would be possible to remove them?? In version 5.58 there were not present.
Thanks!!
The text was updated successfully, but these errors were encountered: