Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify start-up logic. #2

Open
TomGoffrey opened this issue Feb 10, 2021 · 0 comments
Open

Simplify start-up logic. #2

TomGoffrey opened this issue Feb 10, 2021 · 0 comments
Assignees
@TomGoffrey
Labels
enhancement New feature or request

Comments

@TomGoffrey
Copy link
Collaborator

See discussion in #1 .

Both read_deck and problem_setup are called twice during the set-up. A better, less confusing, and less dangerous option would be:

...
CALL read_deck
CALL problem_setup_main

...

SUBROUTINE read_deck
  ...
  READ(..., NML=problem,...)
  CALL problem_setup_control
  REAL(...,NML=control,...)
  ...
END SUBROUTINE read_deck

With the current problem_setup routine split into problem_setup_control and problem_setup_main.
@TomGoffrey TomGoffrey added the enhancement New feature or request label Feb 10, 2021
@TomGoffrey TomGoffrey self-assigned this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomGoffrey TomGoffrey

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TomGoffrey