Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve throughput by reducing number of calls to stats_half_start/stats_half_end #215

Open
justfalter opened this issue Apr 30, 2013 · 2 comments
Milestone

Comments

@justfalter
Copy link
Contributor

Right now, stats_half_start and stats_half_end are called for each packet. In my testing, this accounts for ~13% of ettercap's processing time. If we were to sample once every 100 packets rather than once per packet, we'd significantly reduce it's impact upon Ettercap's performance.

@LocutusOfBorg
Copy link
Contributor

this branch might fix this issue
https://github.com/LocutusOfBorg/Ettercap/tree/fix-215

can anybody please test it?

@koeppea
Copy link
Member

koeppea commented May 19, 2018

@justfalter: Can you check #449 which request to merge the proposed change.
I've done a test case. Despite the bad throughput performance of Ettercap in general, it seems your promising idea didn't work out.
Could you please have a look. Maybe I've done something wrong.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants