Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust MarketplaceVersion in Versions trait implementation for SeqTypes #2251

Open
imabdulbasit opened this issue Nov 4, 2024 · 1 comment · May be fixed by #2262
Open

Adjust MarketplaceVersion in Versions trait implementation for SeqTypes #2251

imabdulbasit opened this issue Nov 4, 2024 · 1 comment · May be fixed by #2262
Assignees
@imabdulbasit @tbro

Comments

@imabdulbasit
Copy link
Contributor

Since we have other upgrades planned in the near future and the marketplace will launch next year, the marketplace version in the Versions trait for SeqType should be temporarily set to a large value, such as u64::MAX
@imabdulbasit imabdulbasit changed the title Adjust MarketplaceVersion in Versions trait implementation for SeqType Adjust MarketplaceVersion in Versions trait implementation for SeqTypes Nov 4, 2024
@tbro
Copy link
Contributor

tbro commented Nov 6, 2024

Not sure its possible to set it to u64::MAX due to type restrictions, but we can set it to some high number we won't hit for some time.

@tbro tbro linked a pull request Nov 6, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imabdulbasit imabdulbasit

@tbro tbro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move marketplace to later version EspressoSystems/espresso-sequencer
2 participants
@imabdulbasit @tbro