Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tool type hints not showing for generic types that take arguments #349

Open
bjsi opened this issue Dec 18, 2024 · 1 comment
Open

Tool type hints not showing for generic types that take arguments #349

bjsi opened this issue Dec 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@bjsi
Copy link
Contributor

bjsi commented Dec 18, 2024

def read(fp: str, line_range: Optional[list[int]] = None, query: Optional[str] = None, names: Optional[list[str]] = None):

Gets turned into this inside the prompt sent to the LLM.

read(fp: str, line_range: Optional, query: Optional, names: Optional):

Ideally it would include the full type information.
@bjsi bjsi changed the title Tool type hints not showing for generic types that take arguements liek Tool type hints not showing for generic types that take arguments Dec 18, 2024
@ErikBjare
Copy link
Owner

Oof, should be an easy fix though.

But why not list[int] | None? I guess it has similar issues?

@ErikBjare ErikBjare added the bug Something isn't working label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ErikBjare @bjsi