Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RepairState, metrics and alarms #553

Open
masokol opened this issue Aug 21, 2023 · 0 comments
Open

Refactor RepairState, metrics and alarms #553

masokol opened this issue Aug 21, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@masokol
Copy link
Contributor

masokol commented Aug 21, 2023 •
edited
Loading

We should do some refactoring regarding schedules and repairState. Currently metrics and alarms depend on when the repairState changes snapshot, i.e if it changes too fast/too slow ecChronos either spams alarms, or don't do alarms, metrics might be outdated/not present as stated in #429.

Proposal:

  • RepairSnapshotProvider (Caches repairStates/repairStateSnapshots and updates them periodically) - Used by schedules to fetch snapshot. The frequency of repairSnapshot updates should be exposed in ecc.yml
@masokol masokol added the enhancement New feature or request label Aug 21, 2023
@masokol masokol self-assigned this Aug 24, 2023
@RhoderickGalero RhoderickGalero moved this to Todo in C2T Sep 6, 2023
@RhoderickGalero RhoderickGalero removed this from C2T Sep 6, 2023
@RhoderickGalero RhoderickGalero moved this to Todo issue in C2T Sep 6, 2023
@masokol masokol removed their assignment Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@masokol