From 8946a782e6045c5ebaa0ff04f03227a8c3158e82 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sergio=20S=C3=A1nchez=20Ram=C3=ADrez?= Date: Mon, 28 Oct 2024 15:19:00 +0100 Subject: [PATCH 1/8] Refactor regenerate-mlir-bindings.yml workflow --- .github/workflows/regenerate-mlir-bindings.yml | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/.github/workflows/regenerate-mlir-bindings.yml b/.github/workflows/regenerate-mlir-bindings.yml index a75bceedf..b22e4064e 100644 --- a/.github/workflows/regenerate-mlir-bindings.yml +++ b/.github/workflows/regenerate-mlir-bindings.yml @@ -22,17 +22,22 @@ jobs: run: | import Pkg Pkg.add("JuliaFormatter") - - run: julia --project=. -e 'using Pkg; pkg"instantiate"; pkg"update"; pkg"precompile"; using Clang; Clang.JLLEnvs.get_system_includes()' + - name: Instantiate dependencies + run: julia --project=. --color=yes {0} + shell: | + using Pkg + pkg"instantiate" + pkg"update" + pkg"precompile" + using Clang + Clang.JLLEnvs.get_system_includes() working-directory: ./deps/ReactantExtra - env: - JULIA_DEPOT_PATH: ${{ runner.temp }}/julia_depot - - run: julia --project=. make-bindings.jl + - run: julia --project=. --color=yes make-bindings.jl working-directory: ./deps/ReactantExtra - env: - JULIA_DEPOT_PATH: ${{ runner.temp }}/julia_depot - run: | chmod -R u+rw ./src/mlir/Dialects/ chmod u+rw ./src/mlir/libMLIR_h.jl + chmod u-x ./src/mlir/libMLIR_h.jl - name: Format code shell: julia --color=yes {0} run: | From 2aaefe037117c8b8ce2bc2fa6cd2d5f9f5f56e13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sergio=20S=C3=A1nchez=20Ram=C3=ADrez?= Date: Mon, 28 Oct 2024 15:21:48 +0100 Subject: [PATCH 2/8] fix typo --- .github/workflows/regenerate-mlir-bindings.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/regenerate-mlir-bindings.yml b/.github/workflows/regenerate-mlir-bindings.yml index b22e4064e..05112cb97 100644 --- a/.github/workflows/regenerate-mlir-bindings.yml +++ b/.github/workflows/regenerate-mlir-bindings.yml @@ -23,8 +23,8 @@ jobs: import Pkg Pkg.add("JuliaFormatter") - name: Instantiate dependencies - run: julia --project=. --color=yes {0} - shell: | + shell: julia --project=. --color=yes {0} + run: | using Pkg pkg"instantiate" pkg"update" From 585568b32451279f19dad76181f463b511166c33 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sergio=20S=C3=A1nchez=20Ram=C3=ADrez?= Date: Mon, 28 Oct 2024 15:25:12 +0100 Subject: [PATCH 3/8] Name step on workflow --- .github/workflows/regenerate-mlir-bindings.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/regenerate-mlir-bindings.yml b/.github/workflows/regenerate-mlir-bindings.yml index 05112cb97..a40721a8d 100644 --- a/.github/workflows/regenerate-mlir-bindings.yml +++ b/.github/workflows/regenerate-mlir-bindings.yml @@ -32,7 +32,8 @@ jobs: using Clang Clang.JLLEnvs.get_system_includes() working-directory: ./deps/ReactantExtra - - run: julia --project=. --color=yes make-bindings.jl + - name: Generate MLIR Bindings + run: julia --project=. --color=yes make-bindings.jl working-directory: ./deps/ReactantExtra - run: | chmod -R u+rw ./src/mlir/Dialects/ From 7ff1e7c980df52860e704c34a131c5f69518a1f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sergio=20S=C3=A1nchez=20Ram=C3=ADrez?= Date: Mon, 28 Oct 2024 15:25:28 +0100 Subject: [PATCH 4/8] Stop tracking file permissions --- .github/workflows/regenerate-mlir-bindings.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/regenerate-mlir-bindings.yml b/.github/workflows/regenerate-mlir-bindings.yml index a40721a8d..ebd79d7f1 100644 --- a/.github/workflows/regenerate-mlir-bindings.yml +++ b/.github/workflows/regenerate-mlir-bindings.yml @@ -35,10 +35,7 @@ jobs: - name: Generate MLIR Bindings run: julia --project=. --color=yes make-bindings.jl working-directory: ./deps/ReactantExtra - - run: | - chmod -R u+rw ./src/mlir/Dialects/ - chmod u+rw ./src/mlir/libMLIR_h.jl - chmod u-x ./src/mlir/libMLIR_h.jl + - run: git config core.fileMode false - name: Format code shell: julia --color=yes {0} run: | From f12b1a15689915e0e5cce2a9e32173a9a005baf5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sergio=20S=C3=A1nchez=20Ram=C3=ADrez?= Date: Mon, 28 Oct 2024 15:33:48 +0100 Subject: [PATCH 5/8] Refactor regenerate-mlir-bindings.yml workflow --- .github/workflows/regenerate-mlir-bindings.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/regenerate-mlir-bindings.yml b/.github/workflows/regenerate-mlir-bindings.yml index ebd79d7f1..76d8d4bad 100644 --- a/.github/workflows/regenerate-mlir-bindings.yml +++ b/.github/workflows/regenerate-mlir-bindings.yml @@ -26,9 +26,8 @@ jobs: shell: julia --project=. --color=yes {0} run: | using Pkg - pkg"instantiate" - pkg"update" - pkg"precompile" + Pkg.instantiate() + Pkg.precompile() using Clang Clang.JLLEnvs.get_system_includes() working-directory: ./deps/ReactantExtra From 4705042e6f830df0cfe14dd3caafc4dd7e5da0dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sergio=20S=C3=A1nchez=20Ram=C3=ADrez?= Date: Mon, 28 Oct 2024 15:41:13 +0100 Subject: [PATCH 6/8] Readd custom depot --- .github/workflows/regenerate-mlir-bindings.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/regenerate-mlir-bindings.yml b/.github/workflows/regenerate-mlir-bindings.yml index 76d8d4bad..0396d95f2 100644 --- a/.github/workflows/regenerate-mlir-bindings.yml +++ b/.github/workflows/regenerate-mlir-bindings.yml @@ -31,9 +31,13 @@ jobs: using Clang Clang.JLLEnvs.get_system_includes() working-directory: ./deps/ReactantExtra + env: + JULIA_DEPOT_PATH: ${{ runner.temp }}/julia_depotkkkkkk - name: Generate MLIR Bindings run: julia --project=. --color=yes make-bindings.jl working-directory: ./deps/ReactantExtra + env: + JULIA_DEPOT_PATH: ${{ runner.temp }}/julia_depot - run: git config core.fileMode false - name: Format code shell: julia --color=yes {0} From 610f38392013fe4890363f464dad432c5cf528a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sergio=20S=C3=A1nchez=20Ram=C3=ADrez?= Date: Mon, 28 Oct 2024 15:41:49 +0100 Subject: [PATCH 7/8] fix typo --- .github/workflows/regenerate-mlir-bindings.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regenerate-mlir-bindings.yml b/.github/workflows/regenerate-mlir-bindings.yml index 0396d95f2..e84cb30f4 100644 --- a/.github/workflows/regenerate-mlir-bindings.yml +++ b/.github/workflows/regenerate-mlir-bindings.yml @@ -32,7 +32,7 @@ jobs: Clang.JLLEnvs.get_system_includes() working-directory: ./deps/ReactantExtra env: - JULIA_DEPOT_PATH: ${{ runner.temp }}/julia_depotkkkkkk + JULIA_DEPOT_PATH: ${{ runner.temp }}/julia_depot - name: Generate MLIR Bindings run: julia --project=. --color=yes make-bindings.jl working-directory: ./deps/ReactantExtra From 3d80cc83007b5affb9f2d035684b933dcbd46dea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sergio=20S=C3=A1nchez=20Ram=C3=ADrez?= Date: Mon, 28 Oct 2024 15:48:54 +0100 Subject: [PATCH 8/8] Readd file permission modification --- .github/workflows/regenerate-mlir-bindings.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/regenerate-mlir-bindings.yml b/.github/workflows/regenerate-mlir-bindings.yml index e84cb30f4..2bbb19c12 100644 --- a/.github/workflows/regenerate-mlir-bindings.yml +++ b/.github/workflows/regenerate-mlir-bindings.yml @@ -38,7 +38,10 @@ jobs: working-directory: ./deps/ReactantExtra env: JULIA_DEPOT_PATH: ${{ runner.temp }}/julia_depot - - run: git config core.fileMode false + - run: | + chmod -R u+rw ./src/mlir/Dialects/ + chmod u+rw ./src/mlir/libMLIR_h.jl + git config core.fileMode false - name: Format code shell: julia --color=yes {0} run: |