Adaptation to changes introduced in EMB v0.7 #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnergyModelsBase
v0.7 changed howStorage
nodes are handled through the introduction of aStorageBehaviour
andAbstractStorageParameter
.As a consequence, we had to update
EMRP
to support the new structures.This PR closes Issue 17.
@hellemo : Do you think the changes warrant an increase to 0.6 or is 0.5.7 sufficient? It includes most likely breaking changes for node development, but not for application through the introduction of the constructors. In practice, other packages should not depend on EMRP. Hence, I would argue that 0.5.7 should be ok.
Draft status until we decided version increase and I updated the NEWS.md