Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Ignore worlds instead of failing. #91

Open
LlmDl opened this issue Oct 23, 2024 · 0 comments
Open

[Feature Request]: Ignore worlds instead of failing. #91

LlmDl opened this issue Oct 23, 2024 · 0 comments
Assignees
Labels
Improvements New improvements

Comments

@LlmDl
Copy link

LlmDl commented Oct 23, 2024

Type of function to add or improvement

Others

Your ideas

It would be nice if the VaultUnlocked implementation did not fail when passed a not-null world:

if (worldName != null) {
return EconomyResponse(amount, getBalance(pluginName, uuid), EconomyResponse.ResponseType.FAILURE, MULTI_WORLD_CURRENCIES_NOT_SUPPORTED_MESSAGE)
}

I think most economy plugins would just direct things to the non-world method like you do anyways.

I found this to be an issue while updating Towny to use VaultUnlocked and found your economy plugin to be the first (almost) working plugin. I did manage to get things working when I modified Towny to pass a null world, but that isn't something I want to do outside of a test environment.

@LlmDl LlmDl added the Improvements New improvements label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvements New improvements
Projects
None yet
Development

No branches or pull requests

2 participants