New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in computation of dist_ref? #7

Open

xiaoxiao112233 opened this issue Dec 21, 2023 · 0 comments

xiaoxiao112233 commented Dec 21, 2023

Hi, there is a typo in this line:

Ref-NeuS/models/renderer.py

Line 367 in ee38ec8

    
           dist_ref = ((points_for_warp.squeeze(1) - rays_o[val_ray_inside_inds]) / rays_o[val_ray_inside_inds])[..., 0].detach()

I think it should be modified as follows:

dist_ref = ((points_for_warp.squeeze(1) - rays_o[val_ray_inside_inds]) / rays_d[val_ray_inside_inds])[..., 0].detach()

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment