Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After Baseline Breathing, I received an error message #24

Open
choipaul92 opened this issue Dec 23, 2024 · 2 comments
Open

After Baseline Breathing, I received an error message #24

choipaul92 opened this issue Dec 23, 2024 · 2 comments
Assignees

Comments

@choipaul92
Copy link

choipaul92 commented Dec 23, 2024

Ver 0.0.7

After completing the Baseline Breathing, I received an error message. After quitting the app and relaunching it, it took me to Cognitive Exercises

Screenshot 2024-12-23 125246

@noah10
Copy link
Contributor

noah10 commented Dec 23, 2024

This is an internet latency problem. I'm not sure we're going to be able to avoid it entirely (though I have one idea that might make it happen a little less often), but when it does happen I can make sure that quitting a restarting the app will force the user to do the paced breathing sessions again so that we get another shot at calculating the hrv peaks.

@noah10 noah10 self-assigned this Dec 23, 2024
@noah10
Copy link
Contributor

noah10 commented Dec 25, 2024

I don't think that we're going to be able to prevent this from ever happening again, but after discussion with Mara I did make some changes to ameliorate the impact if it does happen. This happens when an error occurs in determining the peak power for a given frequency, which we have to do four times (once for the rest breathing and once for each of the three paced breathing measurements). Originally when that happened we forced the user to start over again. Now instead they will just have to re-do the measurement we didn't get a peak power for and all of the measurements after it. If we fail on the rest breathing then obviously this isn't an improvement, but if we fail on the third paced breathing it will be a significant difference.

I've tested this by adding some code that forces a failure when getting the peak power. Other than that, it's essentially impossible to test, so we'll just leave this open for a while and see if it happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants