Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renepay: documentation for renepay & renepaystatus #6526

Merged
merged 1 commit into from
Aug 9, 2023
Merged

renepay: documentation for renepay & renepaystatus #6526

merged 1 commit into from
Aug 9, 2023

Conversation

Lagrang3
Copy link
Collaborator

@Lagrang3 Lagrang3 commented Aug 7, 2023

Requested in issue #6470.

@Lagrang3 Lagrang3 added this to the v23.08 milestone Aug 7, 2023

SYNOPSIS
--------
**(WARNING: experimental)**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a flag --experimental-renepay?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we don't have that flag. The entire plugin is experimental.

Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worried that this will give confusion to people because iirc our experimental stuff is under a single flag. But I think till the people do not start to complain, it is fine

If I was writing the docs, I replace the experimental field and add an alert that explains that we are experimenting with this plugin to improve the pathfinding and the pay user experience.

Just to communicate to the user that it would be great to test it and report bugs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'll change that. Thanks.

@Lagrang3
Copy link
Collaborator Author

Lagrang3 commented Aug 7, 2023

CI tests are failing. But doesn't seem related to my changes.

Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial change only...

doc/schemas/renepay.schema.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2605c92

@rustyrussell rustyrussell merged commit 961ad21 into ElementsProject:master Aug 9, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants