-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renepay: documentation for renepay & renepaystatus #6526
Conversation
doc/lightning-renepay.7.md
Outdated
|
||
SYNOPSIS | ||
-------- | ||
**(WARNING: experimental)** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have a flag --experimental-renepay
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we don't have that flag. The entire plugin is experimental.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worried that this will give confusion to people because iirc our experimental stuff is under a single flag. But I think till the people do not start to complain, it is fine
If I was writing the docs, I replace the experimental field and add an alert that explains that we are experimenting with this plugin to improve the pathfinding and the pay user experience.
Just to communicate to the user that it would be great to test it and report bugs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I'll change that. Thanks.
CI tests are failing. But doesn't seem related to my changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivial change only...
Signed-off-by: Lagrang3 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 2605c92
Requested in issue #6470.