Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci failure after merging an unrelated PR for test_gossip_force_broadcast_channel_msgs #7849

Open
vincenzopalazzo opened this issue Nov 21, 2024 · 1 comment

Comments

@vincenzopalazzo
Copy link
Collaborator

Just keeping track for this

	[<TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/_pytest/runner.py:341>, <TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/flaky/flaky_pytest_plugin.py:146>, <TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/pluggy/_hooks.py:513>, <TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/pluggy/_manager.py:120>, <TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/pluggy/_callers.py:182>, <TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/pluggy/_result.py:100>, <TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/pluggy/_callers.py:103>, <TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/_pytest/runner.py:177>, <TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/_pytest/runner.py:169>, <TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/_pytest/python.py:1792>, <TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/pluggy/_hooks.py:513>, <TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/pluggy/_manager.py:120>, <TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/pluggy/_callers.py:182>, <TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/pluggy/_result.py:100>, <TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/pluggy/_callers.py:103>, <TracebackEntry /home/runner/.cache/pypoetry/virtualenvs/cln-meta-project-AqJ9wMix-py3.10/lib/python3.10/site-packages/_pytest/python.py:194>, <TracebackEntry /home/runner/work/lightning/lightning/tests/test_gossip.py:2326>]
test_channel_persistence passed 1 out of the required 1 times. Success!
test_fetchinvoice_autoconnect passed 1 out of the required 1 times. Success!

===End Flaky Test Report===
=========================== short test summary info ============================
FAILED tests/test_gossip.py::test_gossip_force_broadcast_channel_msgs - AssertionError: assert {'channel_announce': 1, 'channel_update': 2, 'node_announce': 1, 'gossip_filter': 2} == {'channel_announce': 1, 'channel_update': 3, 'node_announce': 1, 'gossip_filter': 1}
  Common items:
  {'channel_announce': 1, 'node_announce': 1}
  Differing items:
  {'channel_update': 2} != {'channel_update': 3}
  {'gossip_filter': 2} != {'gossip_filter': 1}
  Full diff:
    {
     'channel_announce': 1,
  -  'channel_update': 3,
  ?                    ^
  +  'channel_update': 2,
  ?                    ^
  -  'gossip_filter': 1,
  ?                   ^
  +  'gossip_filter': 2,
  ?                   ^
     'node_announce': 1,
    }
============= 1 failed, 75 passed, 6 skipped in 597.03s (0:09:57) ==============
@endothermicdev
Copy link
Collaborator

Ah, it looks like the extra gossip timestamp filter message is cutting off gossipwith too soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants